some small comments on individual patches, and sorry that it took so long to get back to you with the holidays! next round will be faster :)
On December 16, 2024 5:14 am, Thomas Skinner wrote: > Continues work on adding an option to disable querying the userinfo endpoint > for an > OIDC provider. > > Changes since v1: > - Adjust to add option in the UI to enable the functionality > - Add documentation for the option > - Adjust API back to previous behavior > > > access-control: > > Thomas Skinner (1): > fix #4234: add library functions for openid optional userinfo request > > src/PVE/API2/OpenId.pm | 6 +++++- > src/PVE/Auth/OpenId.pm | 7 +++++++ > 2 files changed, 12 insertions(+), 1 deletion(-) > > > docs: > > Thomas Skinner (1): > fix #4234: add docs for openid optional userinfo request > > pveum.adoc | 8 ++++++++ > 1 file changed, 8 insertions(+) > > > manager: > > Thomas Skinner (1): > fix #4234: add GUI option for openid optional userinfo request > > www/manager6/dc/AuthEditOpenId.js | 9 +++++++++ > 1 file changed, 9 insertions(+) > > > perl-rs: > > Thomas Skinner (1): > fix #4234: openid: adjust openid verification function for userinfo > option > > pve-rs/src/openid/mod.rs | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > > proxmox-openid: > > Thomas Skinner (1): > fix #4234: openid: add library functions for optional userinfo > endpoint > > proxmox-openid/src/lib.rs | 30 +++++++++++++++++++++++++++++- > 1 file changed, 29 insertions(+), 1 deletion(-) > > -- > 2.39.5 > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > > > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
