Am 19.12.24 um 12:45 schrieb Fabian Grünbichler: > Folded in Filip's T-B from v2, and applied all but the last > pve-container patch - those checks are there to cancel the migration > early on if a storage that is not supported is contained in the mix.. > > ideally they should move to the storage layer, as the original comment > indicates.. basically a helper that checks export and import formats > (and snapshots/base status) and returns a bool?
Okay, I see. Yes, sounds nice to have for early checks. QemuMigrate can benefit from that too. I guess splitting out the beginning of storage_migrate() with volume_transfer_formats() should be enough? We do need to make sure that plugins correctly treat "subvol" before claiming they can transfer a volume of course, but at least the ones already in the list should already do that (for those it would be a pre-existing bug if not). _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
