This patch series would change the behavior of zones with DHCP enabled as follows:
Currently you need to explicitly configure a DHCP range, otherwise DHCP doesn't work. With this patch series, an IP *always* gets allocated in the IPAM when DHCP is enabled and served via DHCP. This is an okay change in behavior I'd say, since it makes it easier to just use DHCP if you want to manage the whole prefix via DHCP. We should probably document it though. It would also change the behavior for current setups that have DHCP enabled, but no DHCP-Range configured. Might be a fringe case, but maybe still worth to consider since those users would suddenly have a DHCP server running on their PVE node when they re-apply the SDN configuration. Another thing I noticed while testing: Since we now use add_next_freeip() as well, this function does not save the VMID in the PVE IPAM, leading to entries with no VMID and hostname (see PVEPlugin). Would be nice if we added that as well to the add_next_freeip() function - it already is there in add_range_next_freeip() _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
