Am 23.07.24 um 17:25 schrieb Fiona Ebner: > Since there are certain checks that depend on the QEMU binary version, > tests with a fixed QEMU binary version make it less likely to catch > issues on current setups, because current setups will always have a > newer QEMU binary version than the test. > > There are only three tests that explicitly want to test for the binary > version. All others are better of setting the appropriate machine > version they want to test for or just use the current machine version > if no version-specific feature is tested for. > > The minimum binary version that can be used is bumped to 5.0 which was > used in Proxmox VE 6.2, to still allow for long-term regression > testing. > > Split into bite-sized pieces for better reviewability. > > > Fiona Ebner (10): > code cleanup: drop unused parameter from get_vm_machine() > test: bump QEMU version in tests for too new machine type and pve > version > test: cfg2cmd: don't use QEMU binary version less than 4.0 for tests > cfg2cmd: require at least QEMU binary version 4.0 > test: cfg2cmd: don't use QEMU binary version less than 5.0 for tests > cfg2cmd: require at least QEMU binary version 5.0 > cfg2cmd: drop superfluous check for QEMU binary version 4.1 > test: cfg2cmd: don't use QEMU binary version less than 6.0 for tests > test: cfg2cmd: don't use QEMU binary version less than 7.0 for tests > test: cfg2cmd: don't use QEMU binary version less than 8.0 for tests >
applied series with Daniel's R-b and T-b and a few fixes for pre-existing typos as follow-up, thanks! _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
