Am 21.11.24 um 16:13 schrieb Hannes Laimer:
> diff --git a/PVE/QemuServer/Helpers.pm b/PVE/QemuServer/Helpers.pm
> index 0afb6317..1888487e 100644
> --- a/PVE/QemuServer/Helpers.pm
> +++ b/PVE/QemuServer/Helpers.pm
> @@ -167,6 +167,15 @@ sub config_aware_timeout {
> $timeout = 150;
> }
>
> + # Some testing showed that adding a NIC increased the start time by
> ~450ms
> + # consistently across different NIC models, options and already existing
> + # number of NICs.
> + # So 10x that to account for any potential system differences seemed
> + # reasonable. User reports with real-life values (20+: ~50s, 25: 45s,
> 17: 42s)
> + # also make this seem a good value.
> + my $nic_count = grep { /^net\d{1,2}/ } keys %{$config};
I'd use \d+ like in other places.
> + $timeout += scalar ($nic_count * 5);
I meant using scalar() around the grep, not here ;)
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
