Splitting translatable strings deprives translators for context which might be needed for getting the correct tenses or genders. See [1] for example.
[1] https://wiki.gnome.org/TranslationProject(2f)DevGuidelines(2f)Never(20)split(20)sentences.html Signed-off-by: Maximiliano Sandoval <m.sando...@proxmox.com> --- src/panel/WebhookEditPanel.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/panel/WebhookEditPanel.js b/src/panel/WebhookEditPanel.js index ca99333..9a7b222 100644 --- a/src/panel/WebhookEditPanel.js +++ b/src/panel/WebhookEditPanel.js @@ -70,7 +70,7 @@ Ext.define('Proxmox.panel.WebhookEditPanel', { xtype: 'pmxWebhookKeyValueList', name: 'header', fieldLabel: gettext('Headers'), - subject: gettext('Header'), + addLabel: gettext('Add Header'), maskValues: false, cbind: { isCreate: '{isCreate}', @@ -92,7 +92,7 @@ Ext.define('Proxmox.panel.WebhookEditPanel', { xtype: 'pmxWebhookKeyValueList', name: 'secret', fieldLabel: gettext('Secrets'), - subject: gettext('Secret'), + addLabel: gettext('Add Secret'), maskValues: true, cbind: { isCreate: '{isCreate}', @@ -170,8 +170,8 @@ Ext.define('Proxmox.form.WebhookKeyValueList', { // override for column header fieldTitle: gettext('Item'), - // the text for a single element, used for the add button - subject: undefined, + // label displayed in the "Add" button + addLabel: undefined, // will be applied to the textfields maskRe: undefined, @@ -403,7 +403,7 @@ Ext.define('Proxmox.form.WebhookKeyValueList', { }, { xtype: 'button', - text: me.subject ? Ext.String.format(gettext('Add {0}'), me.subject) : gettext('Add'), + text: me.addLabel ? me.addLabel : gettext('Add'), iconCls: 'fa fa-plus-circle', handler: 'addLine', }, -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
