writing it here but applies for basically all your patches: please add some commit message with some context for why/how this is done, that helps on review and on debugging things, e.g. if there's a bug then any more context one has will only help to be able to choose the better solution.
Non-trivial here is mostly meaning the effect of it not how much code is touched or the like. E.g., making a function public or private needs only one line to touch, but normally depends on a good explanation why it's fine to touch the ABI. Fixing hundreds of typos might touch a lot of lines but is often rather trivial, at least if not everything gets completely reworded, that normally can be fine without any commit message body. Most of your commits fall in the first class were at least a short commit message is borderline must-have; borderline because it's late in the release and I do want to move this along. And sure, that could be pointed out earlier, but tbh. this is not a thing that should be pointed out at all for devs with more than a few months of experience (at our project). Am 15.11.24 um 13:10 schrieb Stefan Hanreich: > Signed-off-by: Stefan Hanreich <s.hanre...@proxmox.com> > Reviewed-by: Wolfgang Bumiller <w.bumil...@proxmox.com> > Tested-by: Hannes Dürr <h.du...@proxmox.com> > --- > proxmox-firewall/src/config.rs | 88 ++++++++++++++++++++- > proxmox-firewall/tests/integration_tests.rs | 12 +++ > 2 files changed, 98 insertions(+), 2 deletions(-) > > applied, thanks! _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
