This can happen after a hard failure, e.g. if the vzdump task was
killed. The next backup (after unlocking the VM) would then fail with
> ERROR: VM 125 qmp command 'backup' failed - previous backup not finished
During the failure path of that attempt, 'backup-cancel' is executed
and the subsequent attempt would then work again. Do it up-front with
a warning instead of relying on this behavior.
Signed-off-by: Fiona Ebner <f.eb...@proxmox.com>
---
New in v4.
PVE/VZDump/QemuServer.pm | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/PVE/VZDump/QemuServer.pm b/PVE/VZDump/QemuServer.pm
index bd4795ca..8ebe6772 100644
--- a/PVE/VZDump/QemuServer.pm
+++ b/PVE/VZDump/QemuServer.pm
@@ -59,6 +59,13 @@ sub prepare {
my $running = PVE::QemuServer::Helpers::vm_running_locally($vmid);
+ if ($running && (my $status = mon_cmd($vmid, 'query-backup'))) {
+ if ($status->{status} && $status->{status} eq 'active') {
+ $self->log('warn', "left-over backup job still running inside QEMU
- canceling now");
+ mon_cmd($vmid, 'backup-cancel');
+ }
+ }
+
$task->{disks} = [];
my $conf = $self->{vmlist}->{$vmid} = PVE::QemuConfig->load_config($vmid);
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
