This patch adds a filter to identify services, which are reported as
'not-found' by the api. By default they will not be shown in the UI
anymore, but visibility can still be toggled using a new checkbox.

Signed-off-by: Daniel Herzig <d.her...@proxmox.com>
---
changes since v1:
* applied Thomas' suggestions:
** use camelCase for filtername.
** invert default preselection logic and corresponding UI labelling.

 src/node/ServiceView.js | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/src/node/ServiceView.js b/src/node/ServiceView.js
index 19cfc18..5c6333b 100644
--- a/src/node/ServiceView.js
+++ b/src/node/ServiceView.js
@@ -29,6 +29,8 @@ Ext.define('Proxmox.node.ServiceView', {
            },
        });
 
+       let filterInstalledOnly = record => record.get('unit-state') !== 
'not-found';
+
        let store = Ext.create('Proxmox.data.DiffStore', {
            rstore: rstore,
            sortAfterUpdate: true,
@@ -38,6 +40,24 @@ Ext.define('Proxmox.node.ServiceView', {
                    direction: 'ASC',
                },
            ],
+           filters: [
+               filterInstalledOnly,
+           ],
+       });
+
+       let unHideCB = Ext.create('Ext.form.field.Checkbox', {
+           boxLabel: gettext('Show only installed services'),
+           value: true,
+           boxLabelAlign: 'before',
+           listeners: {
+               change: function(_cb, value) {
+                   if (value) {
+                       store.addFilter([filterInstalledOnly]);
+                   } else {
+                       store.clearFilter();
+                   }
+               },
+           },
        });
 
        let view_service_log = function() {
@@ -166,6 +186,8 @@ Ext.define('Proxmox.node.ServiceView', {
                restart_btn,
                '-',
                syslog_btn,
+               '->',
+               unHideCB,
            ],
            columns: [
                {
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Reply via email to