On 2024-11-07 15:16, Dominik Csapak wrote:
On 11/7/24 14:52, Aaron Lauterer wrote:
gave this a quick test.
two things I noticed:
* root element in tree per tag: wouldn't it be better to override the
display style to 'full'? Otherwise I might have a lot of colorful
dots, but don't know what the tags are called.
that should be the case, but you need the widget toolkit patch installed
for that
Ah okay, for some reason it didn't install in my test cluster. Yeah,
looks good!
* I am not 100% sure, but would it be possible to distinguish guests
that have no tag assigned a bit better? maybe have a default "no-tags"
tree for them?
mhmm. possibly, but i used the same style as we have in the 'pool view'
where guests/storages
outside of pools are also just displayed one level higher
On 2024-11-07 12:25, Dominik Csapak wrote:
this adds a 'tagview' to the web ui, organizing guests by their tags
(for details see the pve-manager patch)
I'm not super happy all in all with how much special casing must be
done, but i could not (yet?) figure out a better way.
changes from v2:
* rebased on master (tooltip generation changed so adapted to that)
* implemented fionas feedback, so selection should stay even when tags
are removed or the selection is changed from the tag view
changes from v1:
* rebase on master
* adapt to recent tooltip changes
* add a comment to TagConfig class to better explain what it does
pve-docs:
Dominik Csapak (1):
gui: add anchor for tags chapter
pve-gui.adoc | 1 +
1 file changed, 1 insertion(+)
proxmox-widget-toolkit:
Dominik Csapak (1):
css: add some conditions to the tag classes for the tag view
src/css/ext6-pmx.css | 22 +++++++++++++++-------
1 file changed, 15 insertions(+), 7 deletions(-)
pve-manager:
Dominik Csapak (1):
ui: implement 'Tag View' for the resource tree
www/manager6/Makefile | 1 +
www/manager6/Workspace.js | 4 +-
www/manager6/form/ViewSelector.js | 28 +++++++++++
www/manager6/grid/ResourceGrid.js | 2 +-
www/manager6/panel/TagConfig.js | 6 +++
www/manager6/tree/ResourceTree.js | 81 ++++++++++++++++++++++++++++---
6 files changed, 113 insertions(+), 9 deletions(-)
create mode 100644 www/manager6/panel/TagConfig.js
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
