On October 30, 2024 2:44 pm, Maximiliano Sandoval wrote:
> The function internally calls
> PVE::Certificate::get_certificate_fingerprint which in turn calls:
>
> ```
> my $fp = Net::SSLeay::X509_get_fingerprint($cert, 'sha256');
> ```
>
> Signed-off-by: Maximiliano Sandoval <m.sando...@proxmox.com>
> ---
> PVE/API2/Nodes.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm
> index e8ff6dd9..1db148af 100644
> --- a/PVE/API2/Nodes.pm
> +++ b/PVE/API2/Nodes.pm
> @@ -2567,7 +2567,7 @@ __PACKAGE__->register_method ({
> renderer => 'duration',
> },
> ssl_fingerprint => {
> - description => "The SSL fingerprint for the node
> certificate.",
> + description => "The SSL SHA-256 fingerprint for the node
> certificate.",
what is an "SSL SHA-256 fingerprint"? the original was already bad, but
this made it worse..
the standard option has "Certificate SHA 256 fingerprint" as
description, IMHO that would already be quite okay here? after all, if
there is only a single fingerprint returned per node, it's quite clear
which certificate it belongs to?
or if you want to make it more specific, then use something like
"The SHA-256 fingerprint of the node's TLS certificate"
> type => 'string',
> optional => 1,
> },
> --
> 2.39.5
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
