Hello, one comment inline.
Skimmed over the code to spot style issues, correctness
was not really checked.
On 2024-10-16 18:47, Daniel Kral wrote:
> Factors out the combo box used for the Async I/O combo box selector,
> which is used in the Disk Edit modal window in the VM "Hardware" tab and
> the "Disks" tab in the Create Wizard, to reuse it in a future commit.
>
> Signed-off-by: Daniel Kral <d.k...@proxmox.com>
> ---
> www/manager6/Makefile | 1 +
> www/manager6/form/AsyncIOTypeSelector.js | 10 ++++++++++
> www/manager6/qemu/HDEdit.js | 10 ++--------
> 3 files changed, 13 insertions(+), 8 deletions(-)
> create mode 100644 www/manager6/form/AsyncIOTypeSelector.js
>
> diff --git a/www/manager6/Makefile b/www/manager6/Makefile
> index 2c3a822b..74a61aa8 100644
> --- a/www/manager6/Makefile
> +++ b/www/manager6/Makefile
> @@ -21,6 +21,7 @@ JSSRC=
> \
> form/ACMEAccountSelector.js \
> form/ACMEPluginSelector.js \
> form/AgentFeatureSelector.js \
> + form/AsyncIOTypeSelector.js \
> form/BackupCompressionSelector.js \
> form/BackupModeSelector.js \
> form/BandwidthSelector.js \
> diff --git a/www/manager6/form/AsyncIOTypeSelector.js
> b/www/manager6/form/AsyncIOTypeSelector.js
> new file mode 100644
> index 00000000..83fb40b5
> --- /dev/null
> +++ b/www/manager6/form/AsyncIOTypeSelector.js
> @@ -0,0 +1,10 @@
> +Ext.define('PVE.form.AsyncIOTypeSelector', {
> + extend: 'Proxmox.form.KVComboBox',
> + alias: ['widget.AsyncIOTypeSelector'],
Usually we use a prefix `pve` (for components defined in pve-manager) or `pmx`
(for components defined in proxmox-widget-toolkit`) prefix, so this
should be `widget.pveAsyncIoTypeSelector`
> + comboItems: [
> + ['__default__', Proxmox.Utils.defaultText + ' (io_uring)'],
> + ['io_uring', 'io_uring'],
> + ['native', 'native'],
> + ['threads', 'threads'],
> + ],
> +});
> diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js
> index b78647ec..37215361 100644
> --- a/www/manager6/qemu/HDEdit.js
> +++ b/www/manager6/qemu/HDEdit.js
> @@ -306,17 +306,11 @@ Ext.define('PVE.qemu.HDInputPanel', {
> name: 'noreplicate',
> },
> {
> - xtype: 'proxmoxKVComboBox',
> + xtype: 'AsyncIOTypeSelector',
> name: 'aio',
> + value: '__default__',
> fieldLabel: gettext('Async IO'),
> allowBlank: false,
> - value: '__default__',
> - comboItems: [
> - ['__default__', Proxmox.Utils.defaultText + ' (io_uring)'],
> - ['io_uring', 'io_uring'],
> - ['native', 'native'],
> - ['threads', 'threads'],
> - ],
> },
> );
>
--
- Lukas
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
