I tested the patch series with the HTTP auto install variant and logged
the POST hook request.
Overall it works as advertised.
Patch 6/17 <common: setup: deserialize `secure_boot` property from
runtime env> runs into a problem if the system isn't using secure boot.
But I think we should fix that in Proxmox/Install/RunEnv.pm to store it
in a way that the JSON stores it not in the form `"secure_boot":""` but
rather as `"secure_boot":0`.
Patch 11/17 <auto-installer: tests: replace manual panic!() with
assert_eq!()> should be dropped, as it will reduce the usefulness of the
output to find out why the test failed. The plan here is to switch that
to, most likely, pretty_assertions.
With this, and the smaller comments on the individual patches, considers
this series:
Tested-By: Aaron Lauterer <a.laute...@proxmox.com>
Reviewed-By: Aaron Lauterer <a.laute...@proxmox.com>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
