On 2024-07-22 18:57, Thomas Lamprecht wrote:
Am 10/07/2024 um 14:42 schrieb Aaron Lauterer:
The ID for the MDS cannot start with a number [0]. The first patch adds
a check for this.
The second patch is the actual fix, by reworking the edit window when
adding new MDS'.
By allowing the users to set the name of the MDS directly, we can catch
the situation where the hostname starts with a number and let the user
decide how it should be named. Similar to what they can already do on
the CLI.
Another approach would be to leave the UI as is and catch the situation
in the backend. If an ID that starts with a number is detected, we could
prepend it with a default string.
[0] https://docs.ceph.com/en/latest/man/8/ceph-mds/
Aaron Lauterer (2):
api: ceph mds: avoid creating MDS when ID starts with number
fix#5570 ui: ceph: make MDS ID configurable
PVE/API2/Ceph/MDS.pm | 2 ++
www/manager6/ceph/ServiceList.js | 21 +++++++++++----------
2 files changed, 13 insertions(+), 10 deletions(-)
applied with a small s/service_id/serviceID/ style fix squashed into the
UI patch plus added the missing space in the subject between "fix" and the
issue ID, thanks!
Oh, I also made a follow-up [0] that makes the field required now to avoid
an API error if the user clears the field before submitting.<
thx for the fixes!
[0]:
https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=d69d4ed8cb276b492a5fe7883f94db777e06d2b2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
