Thanks again! On Fri, Jul 12, 2024 at 11:42:58AM GMT, Aaron Lauterer wrote: > tested this series more thoroughly and checked with an existing root pool > all 3 install options: > > * TUI > * GUI > * auto > > Worked well in 3 cases to rename. > > One oddity seems to be if we cancel the rename in the TUI installer. it > jumps to 100% and stays there and I then need to manually abort. Jumping to > a "setup cancelled" box that we confirm before quitting would be nice. This > is how the GUI installer handles it.
Hm .. this must have existed since the inception of the TUI installer, so it least isn't a (new) regression then. It just probably never occurred that anyone tested/stumbled upon this in the TUI. Thanks for the notice tho! I'll address it in a separate patch though, as it isn't really related to the series. > > Otherwise, besides this and a tiny nit in patch 4, consider this: > > Reviewed-By: Aaron Lauterer <a.laute...@proxmox.com> > Tested-By: Aaron Lauterer <a.laute...@proxmox.com> > > On 2024-07-11 13:57, Christoph Heiss wrote: > > Pretty straight forward overall, implements a check for an existing > > `rpool` on the system and ask the user whether they would like to rename > > it, much in the same way as it works for VGs already. > > > > Without this, the installer would silently create a second (and thus > > conflicting) `rpool` and cause a boot failure after the installation, > > since it does not know which pool to import exactly. > > > > v1: https://lists.proxmox.com/pipermail/pve-devel/2024-May/063874.html > > v2: https://lists.proxmox.com/pipermail/pve-devel/2024-July/064619.html > > > > Notable changes v2 -> v3: > > * make low-level option lvm_auto_rename more generic > > * skip rename prompt in auto-install mode > > > > Notable changes v1 -> v2: > > * incorporated Aarons suggestions from v1 > > * rewrote tests to use a pre-defined input instead > > * moved pool renaming to own subroutine > > * documented all new subroutines > > * split out tests into own patch > > > > Christoph Heiss (4): > > test: add test cases for new zfs module > > low-level: install: check for already-existing `rpool` on install > > install: config: rename option lvm_auto_rename -> > > existing_storage_auto_rename > > low-level: install: automatically rename existing rpools on > > auto-installs > > > > Proxmox/Install.pm | 35 +++++++++++- > > Proxmox/Install/Config.pm | 6 +- > > Proxmox/Sys/ZFS.pm | 20 ++++++- > > proxmox-auto-installer/src/utils.rs | 2 +- > > .../resources/parse_answer/disk_match.json | 2 +- > > .../parse_answer/disk_match_all.json | 2 +- > > .../parse_answer/disk_match_any.json | 2 +- > > .../tests/resources/parse_answer/minimal.json | 2 +- > > .../resources/parse_answer/nic_matching.json | 2 +- > > .../resources/parse_answer/specific_nic.json | 2 +- > > .../tests/resources/parse_answer/zfs.json | 2 +- > > proxmox-installer-common/src/setup.rs | 2 +- > > proxmox-tui-installer/src/setup.rs | 2 +- > > test/Makefile | 7 ++- > > test/zfs-get-pool-list.pl | 57 +++++++++++++++++++ > > 15 files changed, 128 insertions(+), 17 deletions(-) > > create mode 100755 test/zfs-get-pool-list.pl > > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
