Ceph Build Commit in UI - Version 2
===================================
Notable Changes since v1
------------------------
* Use camelCase instead of snake_case for new functions / variables
as per our style guide [0] (thanks Lukas!)
* Refrain from using `const` for things that aren't actual constants
as per our style guide [1] (thanks Lukas!)
* NEW: Patch 09: Increase the default width of the version field in
the OSD tree so that longer strings are immediately readable without
needing to adjust the column widths manually
--> e.g. "18.2.2 (e9fe820e7 -> 69ce99eba)" takes up a lot of space
in the column
* NEW: Patch 10: Include Ceph build commit in the version string
which is part of the object of the `ceph/osd/{osdid}/metadata` call
For a detailed list of changes, please see the comments in the
individual patches.
NOTE: I added Lukas's T-b and R-b tags to all patches except the new
ones, as mentioned in a reply to v1 [2].
Older Versions
--------------
v1: https://lists.proxmox.com/pipermail/pve-devel/2024-April/063772.html
References
----------
[0]: https://pve.proxmox.com/wiki/Javascript_Style_Guide#Casing
[1]: https://pve.proxmox.com/wiki/Javascript_Style_Guide#Variables
[2]: https://lists.proxmox.com/pipermail/pve-devel/2024-June/064084.html
Summary of Changes
------------------
Max Carrara (10):
ceph: tools: refactor installation check as guard clause
ceph: tools: parse Ceph version in separate sub and update regex
ceph: services: remove old cluster broadcast
ceph: services: refactor version existence check as guard clause
utils: align regex of parse_ceph_version with Perl equivalent
ui: ceph: services: parse and display build commit
api: ceph: add build commit of host to Ceph osd index endpoint data
ui: ceph: osd: rework rendering of version field & show build commit
ui: ceph: osd: increase width of version column
api: ceph: change version format in OSD metadata endpoint
PVE/API2/Ceph/OSD.pm | 9 ++++-
PVE/Ceph/Services.pm | 38 ++++++++++----------
PVE/Ceph/Tools.pm | 59 ++++++++++++++++++++++----------
www/manager6/Utils.js | 17 ++++++++-
www/manager6/ceph/OSD.js | 57 +++++++++++++++++++++++++-----
www/manager6/ceph/ServiceList.js | 32 +++++++++++++----
www/manager6/ceph/Services.js | 14 +++++++-
7 files changed, 170 insertions(+), 56 deletions(-)
--
2.39.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
