Am 17/04/2024 um 11:19 schrieb Fiona Ebner: > Am 16.04.24 um 17:02 schrieb Thomas Lamprecht: >> high-level nit: this, and most of the ESXi one, should go into another module >> name space, e.g. PVE::GuestImport:: (or if that's to long, or we really are >> sure >> that other stuff can be imported (I doubt it), then just PVE::Import might be >> fine too). >> > > Hmm, ESXiPlugin.pm is a storage plugin, so it does fit. But no
Yes, ESXiPlugin _is_ a storage plugin, and it must stay there, but about 80% of it's code is not related to being a storage plugin but for importing only, parts of it might be even shareable with other such import related stuff. So what I meant with "**most** of the ESXi one" is that I'd separate these parts from the storage plugin specific code, not moving it completely. > objections to moving it from my side either. And fully agree that OVF.pm > should live somewhere else, it is not a storage plugin. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
