Also need to check for enable/disable of the compression selector,
because with PBS the value zstd is set, but the thread count setting
doesn't apply.
Suggested-by: Thomas Lamprecht <t.lampre...@proxmox.com>
Signed-off-by: Fiona Ebner <f.eb...@proxmox.com>
---
Changes in v4:
* adapt to rename backupPerformance -> backupAdvanced
www/manager6/dc/Backup.js | 18 ++++++++++++++++++
www/manager6/panel/BackupAdvancedOptions.js | 13 +++++++++++++
2 files changed, 31 insertions(+)
diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js
index aaa319f4..221fe17c 100644
--- a/www/manager6/dc/Backup.js
+++ b/www/manager6/dc/Backup.js
@@ -145,6 +145,18 @@ Ext.define('PVE.dc.BackupEdit', {
}
},
+ compressionChange: function(f, value, oldValue) {
+ this.getView().lookup('backupAdvanced').updateCompression(value,
f.isDisabled());
+ },
+
+ compressionDisable: function(f) {
+
this.getView().lookup('backupAdvanced').updateCompression(f.getValue(), true);
+ },
+
+ compressionEnable: function(f) {
+
this.getView().lookup('backupAdvanced').updateCompression(f.getValue(), false);
+ },
+
init: function(view) {
let me = this;
if (view.isCreate) {
@@ -359,6 +371,11 @@ Ext.define('PVE.dc.BackupEdit', {
deleteEmpty: '{!isCreate}',
},
value: 'zstd',
+ listeners: {
+ change: 'compressionChange',
+ disable: 'compressionDisable',
+ enable: 'compressionEnable',
+ },
},
{
xtype: 'pveBackupModeSelector',
@@ -473,6 +490,7 @@ Ext.define('PVE.dc.BackupEdit', {
},
{
xtype: 'pveBackupAdvancedOptionsPanel',
+ reference: 'backupAdvanced',
title: gettext('Advanced'),
cbind: {
isCreate: '{isCreate}',
diff --git a/www/manager6/panel/BackupAdvancedOptions.js
b/www/manager6/panel/BackupAdvancedOptions.js
index 4d74ba3d..11a39352 100644
--- a/www/manager6/panel/BackupAdvancedOptions.js
+++ b/www/manager6/panel/BackupAdvancedOptions.js
@@ -12,6 +12,10 @@ Ext.define('PVE.panel.BackupAdvancedOptions', {
return {};
},
+ controller: {
+ xclass: 'Ext.app.ViewController',
+ },
+
onGetValues: function(formValues) {
if (this.needMask) { // isMasked() may not yet be true if not rendered
once
return {};
@@ -54,6 +58,14 @@ Ext.define('PVE.panel.BackupAdvancedOptions', {
return options;
},
+ updateCompression: function(value, disabled) {
+ if (!disabled && value === 'zstd') {
+ this.lookup('zstdThreadCount').setDisabled(false);
+ } else {
+ this.lookup('zstdThreadCount').setDisabled(true);
+ }
+ },
+
column1: [
{
xtype: 'pveBandwidthField',
@@ -71,6 +83,7 @@ Ext.define('PVE.panel.BackupAdvancedOptions', {
{
xtype: 'proxmoxintegerfield',
name: 'zstd',
+ reference: 'zstdThreadCount',
fieldLabel: Ext.String.format(gettext('{0} Threads'), 'Zstd'),
fieldStyle: 'text-align: right',
emptyText: gettext('use fallback'),
--
2.39.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
