Am 11.04.24 um 20:07 schrieb Thomas Lamprecht: > On 11/04/2024 11:29, Fiona Ebner wrote: >> It's a property string, because that avoids having an implicit >> "enabled" as part of a 'fleecing-storage' property. And there likely >> will be more options in the future, e.g. threshold/limit for the >> fleecing image size. >> >> Storage is non-optional, so the storage choice needs to be a conscious >> decision. Can allow for a default later, when a good choice can be >> made further down the stack. The original idea with "same storage as >> VM disk" is not great, because e.g. for LVM, it would require the same >> size as the disk up front. >> >> Signed-off-by: Fiona Ebner <f.eb...@proxmox.com> >> --- >> src/PVE/VZDump/Common.pm | 25 +++++++++++++++++++++++++ >> 1 file changed, 25 insertions(+) >> >> > > applied, but massaged in having the whitespace on the continued line for > multi-line strings, not on the previous (we should actually add that to > the style guide), thanks!
Sorry, I always forget the preferred way. Added to the style guide now: https://pve.proxmox.com/wiki/Perl_Style_Guide#Wrapping_Strings _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
