On Tue, Apr 02, 2024 at 04:55:11PM +0200, Aaron Lauterer wrote: [..] > > > > - While trying out different configurations, I wondered if for the > > network something like this would be better for static IPs: > > > > [network.manual] > > cidr = ".." > > dns = ".." > > [..] > > > > .. keeping the `network.use_dhcp` option as before. Would simplify > > some checks now and provide good future-proofing for any new options > > that might get added. > > > > Thereby basically modelling > > `proxmox_auto_installer::answer::NetworkSettings` enum nearly 1:1 to > > the TOML config. > > okay, so that in the DHPC case, it could be > [network] > use_dhcp = true > > and in the manual case, either > [network] > manual.cidr = "…" > manual.dns = "…" > > and so forth, or, to keep it simpler, like your example with > [network.manual] defining the overall manual key.
Yeah, exactly. > > This will make it slightly more elaborate to document, as we need to dig > deeper into how TOML works and that there are multiple ways to define the > same hierarchy. But it could be worth it to keep the definition cleaner. > > Some more feedback in that regard might be useful, especially since changing > the format later on will be, as you described it, a PITA :) Feel free though to not block this series on further feedback for this! :^) Just came to mind while pondering over this and trying different settings - but doesn't change anything wrt. functionality really. IMO we can change/break the answer file format at least with a new major release later on, so it's not completely set in stone after all. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
