Am 26/02/2024 um 17:50 schrieb Christoph Heiss:
> Using full seconds as a granularity for sleeping between waitpid()'s is
> way too much and unnecessarily slows down the installation a lot. Most
> processes take a few moments after closing their stdin/stdout to
> actually exit fully, which means that we would sleep a second in most
> cases.
>
> Lower it to 0.1 second, which immensely improves the situation.
>
> Some values for comparison; tui-installer on the same bog-standard
> 2-core, SeaBIOS, ext4, virtio VM (roughly averaged over multiple runs):
>
> * 8.0 ISO (baseline): ~2:30 min
> * w/o patch: ~9:00 min
> * w/ patch: ~2:30 min
>
> Values measured are from pressing the 'Install' button until the
> autoreboot dialog (aka. install finished) popped up.
>
> Fixes: 152bbef ("sys: command: factor out kill() + waitpid() from
> run_command()")
> Reported-by: Stoiko Ivanov <s.iva...@proxmox.com>
> Reported-by: Filip Schauer <f.scha...@proxmox.com>
> Signed-off-by: Christoph Heiss <c.he...@proxmox.com>
> ---
> Proxmox/Sys/Command.pm | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>
applied this already yesterday, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
