Am 16/11/2023 um 20:59 schrieb Stoiko Ivanov: > without this patch the hostname ends up as the empty string in > run-env-info.json, which results in a parse-error in the TUI code > (an empty string is not None, but still too short as hostname) > > Minimally tested on a VM. > > Fixes: bda1cdf699a3fcfc1cf3cfa446b1493689fc8eb8 > Signed-off-by: Stoiko Ivanov <s.iva...@proxmox.com> > --- > Proxmox/Install/RunEnv.pm | 4 +++- > Proxmox/Sys/Net.pm | 2 +- > 2 files changed, 4 insertions(+), 2 deletions(-) > >
applied, with some code/naming (style) clean up done in a follow-up, thanks! E.g., the method is now named get_dhcp_fqdn, as it doesn't parses out the first part (sometimes also just named hostname) anymore, but rather passes along the full FQDN, be it just the local part or a full host.domain one. @christoph: please give this another sanity check. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
