I think this can be part of the auto-installer itself, instead of introducing another shell script somewhere. While yes, "do one thing and do it well", its a rather small part and not unreasonable to move it directly into the auto-installer. Or have a separate Rust-written executable for this, both have their own merits of course - just not shell :^)
If and when we add other methods of retrieving the answer file (as illustrated in the cover letter), it makes sense to write this in a sensible language and have a modular architecture, rather than arcane shell scripting. (Apart from the fact that the latter might even be nearly impossible for some things.) On Tue, Sep 05, 2023 at 03:28:29PM +0200, Aaron Lauterer wrote: > > With the auto installer present, the crucial question is how we get the > answer file. This script implements the way of a local disk/partition > present, labelled 'proxmoxinst', lower or upper case, with the > 'answer.toml' file in the root directory. > > We either want to use it directly and call it from 'unconfigured.sh' or > see it as a first approach to showcase how it could be done. > > Signed-off-by: Aaron Lauterer <a.laute...@proxmox.com> > --- > start_autoinstall.sh | 50 ++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 50 insertions(+) > create mode 100755 start_autoinstall.sh > > [..] _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
