Booting in legacy BIOS mode on 4Kn disks is generally unsupported, or rather, simply does not work. The GUI installer already checks that properly for LVM and ZFS, but is missing it for Btrfs, so extend the check appropriately.
Further, the TUI installer only checked it for ZFS RAIDs, but not for LVM and Btrfs. Add proper checks there as well, such that the user gets immediate feedback early than during the install process. Seems nobody noticed yet, but apparently 4Kn disks are pretty rare these days anyway. Prerequisites ------------- This series is based on top of [PATCH installer 0/6] some small, assorted fixes & cleanups https://lists.proxmox.com/pipermail/pve-devel/2023-August/058708.html which fixes another 4Kn disk issue. Testing ------- Tested by creating a block device with 4K sectorsize using the following QEMU args: -device virtio-blk,drive=testdrive4k,logical_block_size=4096,physical_block_size=4096 -drive file=/path/to/4k-testdisk.img,if=none,id=testdrive4k The 4k-testdisk.img was created with: qemu-img create -f qcow2 /path/to/4k-testdisk.img 16G Christoph Heiss (2): raid setup: btrfs: do not allow legacy BIOS boot on 4Kn disks tui: disallow legacy BIOS boot from 4Kn disks for all filesystems Proxmox/Install.pm | 4 + proxmox-tui-installer/src/main.rs | 2 +- proxmox-tui-installer/src/setup.rs | 2 +- proxmox-tui-installer/src/views/bootdisk.rs | 171 ++++++++------------ 4 files changed, 74 insertions(+), 105 deletions(-) -- 2.41.0 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
