Tested the whole series, using Debian 12 and Windows 11 as guest
machines. Works fine with both.
Two small things overall that I noticed, although only really pertaining
to documentation:
* It should be explained in the docs and via a tooltip in the GUI
what the "mount tag" is / does. This might not be immediately
obvious to all users.
* It should also be mentioned in the docs that for it to work under
Windows, the WinFsp [0] drivers are needed, in addition to the
virtio ones.
Consider the series:
Tested-by: Christoph Heiss <c.he...@proxmox.com>
[0] https://winfsp.dev/
On Thu, Jul 06, 2023 at 12:54:10PM +0200, Markus Frank wrote:
>
> cluster:
>
> Markus Frank (1):
> add mapping/dir.cfg for resource mapping
>
> src/PVE/Cluster.pm | 1 +
> src/pmxcfs/status.c | 1 +
> 2 files changed, 2 insertions(+)
>
>
> guest-common:
>
> Markus Frank (1):
> add DIR mapping config
>
> src/Makefile | 1 +
> src/PVE/Mapping/DIR.pm | 175 +++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 176 insertions(+)
> create mode 100644 src/PVE/Mapping/DIR.pm
>
>
> qemu-server:
>
> v6:
> * added virtiofsd dependency
> * 2 new patches:
> * Permission check for virtiofs directory access
> * check_local_resources: virtiofs
>
> v5:
> * allow numa settings with virtio-fs
> * added direct-io & cache settings
> * changed to rust implementation of virtiofsd
> * made double fork and closed all file descriptor so that the lockfile
> gets released.
>
> v3:
> * created own socket and get file descriptor for virtiofsd
> so there is no race between starting virtiofsd & qemu
> * added TODO to replace virtiofsd with rust implementation in bookworm
> (I packaged the rust implementation for bookworm & the C implementation
> in qemu will be removed in qemu 8.0)
>
> v2:
> * replaced sharedfiles_fmt path in qemu-server with dirid:
> * user can use the dirid to specify the directory without requiring root
> access
>
> Markus Frank (3):
> feature #1027: virtio-fs support
> Permission check for virtiofs directory access
> check_local_resources: virtiofs
>
> PVE/API2/Qemu.pm | 18 +++++
> PVE/QemuServer.pm | 167 ++++++++++++++++++++++++++++++++++++++-
> PVE/QemuServer/Memory.pm | 25 ++++--
> debian/control | 1 +
> 4 files changed, 204 insertions(+), 7 deletions(-)
>
>
> manager:
>
> v6: completly new except "ui: added options to add virtio-fs to qemu config"
>
> Markus Frank (5):
> api: add resource map api endpoints for directories
> ui: add edit window for dir mappings
> ui: ResourceMapTree for DIR
> ui: form: add DIRMapSelector
> ui: added options to add virtio-fs to qemu config
>
> PVE/API2/Cluster/Mapping.pm | 7 +
> PVE/API2/Cluster/Mapping/DIR.pm | 299 ++++++++++++++++++++++++++++
> PVE/API2/Cluster/Mapping/Makefile | 3 +-
> www/manager6/Makefile | 4 +
> www/manager6/Utils.js | 1 +
> www/manager6/dc/Config.js | 10 +
> www/manager6/dc/DIRMapView.js | 50 +++++
> www/manager6/form/DIRMapSelector.js | 63 ++++++
> www/manager6/qemu/HardwareView.js | 19 ++
> www/manager6/qemu/VirtiofsEdit.js | 120 +++++++++++
> www/manager6/window/DIRMapEdit.js | 186 +++++++++++++++++
> 11 files changed, 761 insertions(+), 1 deletion(-)
> create mode 100644 PVE/API2/Cluster/Mapping/DIR.pm
> create mode 100644 www/manager6/dc/DIRMapView.js
> create mode 100644 www/manager6/form/DIRMapSelector.js
> create mode 100644 www/manager6/qemu/VirtiofsEdit.js
> create mode 100644 www/manager6/window/DIRMapEdit.js
>
> --
> 2.39.2
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
