to avoid duplicate work, always set 'volid' to the backup volume's volid, if it was successfully parsed as such.
Signed-off-by: Fabian Grünbichler <f.gruenbich...@proxmox.com> --- PVE/API2/Qemu.pm | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index d0c199bf..b7832d88 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -750,20 +750,20 @@ my $parse_restore_archive = sub { my ($archive_storeid, $archive_volname) = PVE::Storage::parse_volume_id($archive, 1); + my $res = {}; + if (defined($archive_storeid)) { my $scfg = PVE::Storage::storage_config($storecfg, $archive_storeid); + $res->{volid} = $archive; if ($scfg->{type} eq 'pbs') { - return { - type => 'pbs', - volid => $archive, - }; + $res->{type} = 'pbs'; + return $res; } } my $path = PVE::Storage::abs_filesystem_path($storecfg, $archive); - return { - type => 'file', - path => $path, - }; + $res->{type} = 'file'; + $res->{path} = $path; + return $res; }; -- 2.39.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel