On 6/1/23 16:24, Thomas Lamprecht wrote:
Don't we reuse that on PBS/PMG too, and if is it working there?
The commit message isn't excactly telling... ;-)
on PMG we only allow creating bonds in the GUI. On PBS we allow bonds and
bridges. Though that makes we wonder what the use case for a bridge on PBS is.
What about safeguarding the vids to only be added/used if we are on PVE?
Something like `if (PVE) {`?
Am 13/04/2023 um 17:10 schrieb Aaron Lauterer:
Signed-off-by: Aaron Lauterer <a.laute...@proxmox.com>
---
src/node/NetworkEdit.js | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/src/node/NetworkEdit.js b/src/node/NetworkEdit.js
index bb9add3..e4ab158 100644
--- a/src/node/NetworkEdit.js
+++ b/src/node/NetworkEdit.js
@@ -57,11 +57,26 @@ Ext.define('Proxmox.node.NetworkEdit', {
}
if (me.iftype === 'bridge') {
+ let vids = Ext.create('Ext.form.field.Text', {
+ fieldLabel: gettext('Bridge VIDS'),
+ name: 'bridge_vids',
+ emptyText: '2-4094',
+ disabled: true,
+ autoEl: {
+ tag: 'div',
+ 'data-qtip': gettext('Space-separated list of VLANs and
ranges, for example: 2 4 100-200'),
+ },
+ });
column2.push({
xtype: 'proxmoxcheckbox',
fieldLabel: gettext('VLAN aware'),
name: 'bridge_vlan_aware',
deleteEmpty: !me.isCreate,
+ listeners: {
+ change: function(f, newVal) {
+ vids.setDisabled(!newVal);
+ },
+ },
});
column2.push({
xtype: 'textfield',
@@ -72,6 +87,7 @@ Ext.define('Proxmox.node.NetworkEdit', {
'data-qtip': gettext('Space-separated list of interfaces,
for example: enp0s0 enp1s0'),
},
});
+ advancedColumn2.push(vids);
} else if (me.iftype === 'OVSBridge') {
column2.push({
xtype: 'textfield',
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
