Adds a default-on checkbox to the QEMU Guest Agent feature selector
controlling the 'fs-freeze-on-backup' option. If unchecked, an
additional warning is displayed that backups can potentially corrupt
with this setting off.
Signed-off-by: Christoph Heiss <c.he...@proxmox.com>
---
The qemu-server part has already been applied; commit 93e21fd.
Changes v1 -> v2:
* Rename option from 'fsfreeze_thaw' to 'freeze-fs-on-backup'
* Adapt option descriptions as suggested
Changes v2 -> v3:
* Fold gettext() onto one line, as the parser does not support multiple
lines (yet)
* Change let -> const declaration
www/manager6/Utils.js | 2 ++
www/manager6/form/AgentFeatureSelector.js | 30 ++++++++++++++++++++++-
2 files changed, 31 insertions(+), 1 deletion(-)
diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index d8c0bf5a..e6c7861a 100644
--- a/www/manager6/Utils.js
+++ b/www/manager6/Utils.js
@@ -475,6 +475,8 @@ Ext.define('PVE.Utils', {
virtio: "VirtIO",
};
displayText = map[value] || Proxmox.Utils.unknownText;
+ } else if (key === 'freeze-fs-on-backup' &&
PVE.Parser.parseBoolean(value)) {
+ continue;
} else if (PVE.Parser.parseBoolean(value)) {
displayText = Proxmox.Utils.enabledText;
}
diff --git a/www/manager6/form/AgentFeatureSelector.js
b/www/manager6/form/AgentFeatureSelector.js
index 0dcc6ecb..81ea42ea 100644
--- a/www/manager6/form/AgentFeatureSelector.js
+++ b/www/manager6/form/AgentFeatureSelector.js
@@ -21,6 +21,26 @@ Ext.define('PVE.form.AgentFeatureSelector', {
},
disabled: true,
},
+ {
+ xtype: 'proxmoxcheckbox',
+ boxLabel: gettext('Freeze/thaw guest filesystems on backup for
consistency'),
+ name: 'freeze-fs-on-backup',
+ reference: 'freeze_fs_on_backup',
+ bind: {
+ disabled: '{!enabled.checked}',
+ },
+ disabled: true,
+ uncheckedValue: '0',
+ defaultValue: '1',
+ },
+ {
+ xtype: 'displayfield',
+ userCls: 'pmx-hint',
+ value: gettext('Freeze/thaw for guest filesystems disabled. This
can lead to inconsistent disk backups.'),
+ bind: {
+ hidden: '{freeze_fs_on_backup.checked}',
+ },
+ },
{
xtype: 'displayfield',
userCls: 'pmx-hint',
@@ -47,12 +67,20 @@ Ext.define('PVE.form.AgentFeatureSelector', {
],
onGetValues: function(values) {
- var agentstr = PVE.Parser.printPropertyString(values, 'enabled');
+ if (PVE.Parser.parseBoolean(values['freeze-fs-on-backup'])) {
+ delete values['freeze-fs-on-backup'];
+ }
+
+ const agentstr = PVE.Parser.printPropertyString(values, 'enabled');
return { agent: agentstr };
},
setValues: function(values) {
let res = PVE.Parser.parsePropertyString(values.agent, 'enabled');
+ if (!Ext.isDefined(res['freeze-fs-on-backup'])) {
+ res['freeze-fs-on-backup'] = 1;
+ }
+
this.callParent([res]);
},
});
--
2.39.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
