I did test it for a bit, and it seems to work a lot better than the last iteration :)
From a high level user perspective, I would like to see the following:
- a list of configured tags that I am allowed to set in the drop down (the 
user-tag-privileges list)
- better error messages that tell me which tag caused which problem. For example 
something like: "tag foo is not in list of allowed tags" or "tag bar is reserved 
for admins"
- as user, no GUI action buttons on admin tags


Another thing that I noticed, which is not exclusive to this patch series, is that a user without permissions can still open the options in the cluster->options panel and will only get an error when trying to save the changes. Not allowing to open the edit windows could probably be a good idea.

Will go through the code and add some more smaller details that I found in the respective patches

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Reply via email to