All in all LGTM, one small UX thing that i am not sure if we can improve without making it way more complicated:
We now preselect the current node and leave the restriction out. We then restrict when the node changes, but remove the restriction again when we select the current node. Maybe we want to just leave the restriction out when we load the panel up, but always restrict when a user sets the node? (as in, if i manually select the current node again, restrict it?) not sure if we'd want that or leave it like it is (or something else entirely?) @Thomas do you have any thoughts about that? Aside from that, consider the series: Reviewed-by: Dominik Csapak <d.csa...@proxmox.com> Tested-by: Dominik Csapak <d.csp...@proxmox.com> On 9/30/22 14:38, Stefan Hrdlicka wrote:
V1 -> V2: # pve-storage * removed because patch is not needed # pve-manager (1/3) * remove storage controller from V1 * added custom ComboBox with API URL & setNodeName function * added scan node selection for iSCSI * scan node selection field no longer send to server ## (optional) pve-manager (2/3): cleanup related files * var to let statement change * some indentation ## ((very) optional) pve-manager (3/3): cleanup all var statements * replaces all var with let statements V2 -> V3: # pve-manager (1/2) * fix broken interface (broken in V2 ) * improve tooltip * replace jNodeSelector function with class object (PVE.panel.StorageBaseWithNodeSelector) # other things: * removed very optional cleanup * nothing changed for "Base storage" selector. It is still possible to select for example an iSCSI device only availabe on one node that isn't availabe on the other ones. I wasn't sure if this should be changed in this context as well. V3 -> V4: # pve-manager (1/2) * "localhost" is set for "Scan Node" * if another node is selcted and the "X" (clear) is used, localhost is set as the value again * use lookupReference * moved used template literals for building path strings V4 -> V5: # pve-manager (1/2) * s/lookupReference/lookup/ * move ComboBoxSetStoreNode & StrageScanNodeSelector to www/manager6/form * move array pushes to initialization of array V5 -> V6: # pve-manager (1/2) * set default value of "Scan node" to Proxmox.NodeName * don't allow empty "Scan node" Stefan Hrdlicka (2): fix #2822: add iscsi, lvm, lvmthin & zfs storage for all cluster nodes cleanup: "var" to "let", fix some indentation in related files www/manager6/Makefile | 2 + www/manager6/form/ComboBoxSetStoreNode.js | 16 +++++ www/manager6/form/StorageScanNodeSelector.js | 31 +++++++++ www/manager6/storage/Base.js | 11 +-- www/manager6/storage/IScsiEdit.js | 35 +++++++--- www/manager6/storage/LVMEdit.js | 43 +++++++++--- www/manager6/storage/LvmThinEdit.js | 70 ++++++++++++++------ www/manager6/storage/ZFSPoolEdit.js | 51 +++++++++----- 8 files changed, 199 insertions(+), 60 deletions(-) create mode 100644 www/manager6/form/ComboBoxSetStoreNode.js create mode 100644 www/manager6/form/StorageScanNodeSelector.js
_______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
