Am 21/07/2022 um 12:45 schrieb Matthias Heiserer:
> This makes it consistent with the naming scheme in PVE/GUI.
> Keep value for API stability reasons, and remove it in next major version.
>
> Signed-off-by: Matthias Heiserer <m.heise...@proxmox.com>
> ---
> src/tools/disks/smart.rs | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
>
applied, with Dominik's T-b/R-b and a small follow up (see below), thanks!
> diff --git a/src/tools/disks/smart.rs b/src/tools/disks/smart.rs
> index 3738cdfd..787971e9 100644
> --- a/src/tools/disks/smart.rs
> +++ b/src/tools/disks/smart.rs
> @@ -25,8 +25,11 @@ pub enum SmartStatus {
> pub struct SmartAttribute {
> /// Attribute name
> name: String,
> - /// Attribute raw value
> + // fixme remove value in major release
Please capitalize FIXME, as that way most editors will highlight it by default,
additionally include the specific major release this should be removed. I
changed
it to:
// FIXME: remove value with next major relase (PBS 3.0)
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
