includes the following improvements: * increases 'force cleanup' timeout to 60s (from 5) * saves individual timeout for each vm * don't force cleanup for vms where normal cleanup worked * sending QMP quit instead of SIGTERM (less log noise)
i opted for variant 1 of wbumillers suggestions, as it yielded the least change and still results in clean code changes from v1: * remove 'alarm' calls altogether and use epoll_waits' timeout mechanic instead * call 'time()' only once and give it as user data to the function * change the function singatures and cast on callsite with '(GFunc)' for the g_slist_foreach calls * change to <s> for the usage output for timeouts Dominik Csapak (3): qmeventd: rework 'forced_cleanup' handling and set timeout to 60s qmeventd: cancel 'forced cleanup' when normal cleanup succeeds qmeventd: send QMP 'quit' command instead of SIGTERM qmeventd/qmeventd.c | 104 +++++++++++++++++++++++++++----------------- qmeventd/qmeventd.h | 2 + 2 files changed, 67 insertions(+), 39 deletions(-) -- 2.30.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
