Am 22.06.22 um 13:51 schrieb Alexandre Derumier: > Hi, > > This is an attempt to cleanup current behaviour of cloudinit online changes. > > Currently, we setup cloudinit options as pending, until we generate the > config drive. > > This is not 100% true, because some option like vm name, nic mac address can > be changed, > without going to pending, so user can't known if it need to regenerated it. > > Also, some can are very difficult to handle, if you hotplug a nic but it's > failing,so pending, > then you defined an ipconfig, and then you revert hotplug. > or if you delete a nic, the ipconfig is no more displayed in the gui. > > > So, instead of setting cloudinit values in pending, > this patch serie copy the current cloudinit config in a new section > [special:cloudinit], > when the config drive is generated. > This is only an hint, to allow to display diff between the generated cloudinit > drive, and the current vm config. > > A new specific cloudinit config api is added too displaying the diff between > current and generated config. > > Reminder: This need pve-manager depency bump first to check the version for > live migration.
Without 10/10 and the version check in 03/10 adapted in accordance with the above-mentioned bump (best done when applying): Reviewed-by: Fiona Ebner <f.eb...@proxmox.com> _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
