On 06.07.2022 18:09, Daniel Tschlatscher wrote:
As we talked off list: The 501 error is what we currently return. I don't mind using more descriptive ones, but as it changes the API I'm not sure if this patch is the right place.All errors above return HTTP status 501 ("Not implemented") which I think is rather confusing, even if they include a descriptive error message. I'd wager that it would be better to differentiate between malformed multi-form data and internal server errors, and return 400 for incorrect user inputs. This makes it much easier for anyone (that is not a browser) to interface with this part of the API.I am not quite sure how much precedence fixing the errors above should have, as even most API users will probably never encounter them. However, I feel like that at the very least the basic error message should be revised to no longer return 501 and to include a more descriptive error message than just "upload failed".
Thanks for testing! _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
