if the configured display hardware has the (optional) default type, but some other attribute is set, this would match against `undef` and spew lots of warnings in the logs.
Signed-off-by: Fabian Grünbichler <f.gruenbich...@proxmox.com> --- see https://forum.proxmox.com/threads/pvedaemon-use-of-uninitialized-value-in-pattern-match.110183/ PVE/API2/Qemu.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index a8246574..99b426ec 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -2443,8 +2443,9 @@ __PACKAGE__->register_method({ if ($conf->{vga}) { my $vga = PVE::QemuServer::parse_vga($conf->{vga}); - $status->{spice} = 1 - if $vga->{type} =~ /^virtio/ || PVE::QemuServer::vga_conf_has_spice($conf->{vga}); + my $spice = defined($vga->{type}) && $vga->{type} =~ /^virtio/; + $spice ||= PVE::QemuServer::vga_conf_has_spice($conf->{vga}); + $status->{spice} = 1 if $spice; } $status->{agent} = 1 if PVE::QemuServer::get_qga_key($conf, 'enabled'); -- 2.30.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
