This allow to regenerate config drive if pending values exist when we change vm options.
Signed-off-by: Alexandre Derumier <aderum...@odiso.com> --- PVE/QemuServer.pm | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index a38ae3e..babc86f 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -303,7 +303,7 @@ my $confdesc = { optional => 1, type => 'string', format => 'pve-hotplug-features', description => "Selectively enable hotplug features. This is a comma separated list of" - ." hotplug features: 'network', 'disk', 'cpu', 'memory' and 'usb'. Use '0' to disable" + ." hotplug features: 'network', 'disk', 'cpu', 'memory', 'usb' and 'cloudinit'. Use '0' to disable" ." hotplug completely. Using '1' as value is an alias for the default `network,disk,usb`.", default => 'network,disk,usb', }, @@ -1356,7 +1356,7 @@ sub parse_hotplug_features { $data = $confdesc->{hotplug}->{default} if $data eq '1'; foreach my $feature (PVE::Tools::split_list($data)) { - if ($feature =~ m/^(network|disk|cpu|memory|usb)$/) { + if ($feature =~ m/^(network|disk|cpu|memory|usb|cloudinit)$/) { $res->{$1} = 1; } else { die "invalid hotplug feature '$feature'\n"; @@ -5003,8 +5003,16 @@ sub vmconfig_hotplug_pending { delete $conf->{pending}->{$opt}; } } - PVE::QemuConfig->write_config($vmid, $conf); + + if($hotplug_features->{cloudinit}) { + my $pending = PVE::QemuServer::Cloudinit::get_pending_config($conf, $vmid); + my $regenerate = undef; + for my $item (@$pending) { + $regenerate = 1 if defined($item->{delete}) or defined($item->{pending}); + } + PVE::QemuServer::vmconfig_update_cloudinit_drive($storecfg, $conf, $vmid) if $regenerate; + } } sub try_deallocate_drive { -- 2.30.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel