On Tue, 3 May 2022 13:08:47 +0200
Dominik Csapak <d.csa...@proxmox.com> wrote:
> those would not get assinged a usage and thus appear in the list
> when we want to select a partition (e.g. for creating a zpool)
>
> since we cannot do anything with such a partition, return the usage
> 'Extended Partition' for these.
>
> Signed-off-by: Dominik Csapak <d.csa...@proxmox.com>
> ---
> PVE/Diskmanage.pm | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/PVE/Diskmanage.pm b/PVE/Diskmanage.pm
> index d67cc6b..f693d00 100644
> --- a/PVE/Diskmanage.pm
> +++ b/PVE/Diskmanage.pm
> @@ -647,6 +647,8 @@ sub get_disks {
> if $parttype eq 'c12a7328-f81f-11d2-ba4b-00a0c93ec93b';
> return 'ZFS reserved'
> if $parttype eq '6a945a3b-1dd2-11b2-99a6-080020736631';
> + return 'Extended Partition'
> + if $parttype eq '0x5';
This looks like a MBR partitiontype (both the length and the concept of
extended partition seem MBR-related) - Do we want to support MBR disks?
(we do not in the installer and when initializing a new disk)
Any pointer to where this could be needed?
Really meant as an expression of my confusion - am fine if we want to
support this and the patch LGTM.
> ..snip..
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
