previously we had a default of 'root@pve', which doesn't exist. since the username is only relevant for the task logs, we can change it to 'root@pam' without ill effects.
also add a warning in case there are other call sites that we missed where fork_worker is called without a user variable (found call sites only in pve-container where this was unset, namely in 'push_file' and 'pull_file'). Signed-off-by: Oguz Bektas <o.bek...@proxmox.com> --- src/PVE/RESTEnvironment.pm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/PVE/RESTEnvironment.pm b/src/PVE/RESTEnvironment.pm index 1b2af08..5352aad 100644 --- a/src/PVE/RESTEnvironment.pm +++ b/src/PVE/RESTEnvironment.pm @@ -492,7 +492,10 @@ sub fork_worker { $dtype = 'unknown' if !defined ($dtype); $id = '' if !defined ($id); - $user = 'root@pve' if !defined ($user); + if (!defined($user)) { + warn 'Worker user was not specified, defaulting to "root@pam"!'; + $user = 'root@pam'; + } my $sync = ($self->{type} eq 'cli' && !$background) ? 1 : 0; -- 2.30.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel