On 24.01.22 16:11, Aaron Lauterer wrote: > Ensure that the user provided $secret ends in a newline. Otherwise we > will have Input/output errors from rados_connect. > > For consistency and possible future proofing, also add a newline to > CephFS secrets. > > Signed-off-by: Aaron Lauterer <a.laute...@proxmox.com> > --- > > changes: > - instead conditional with regex, use chomp and always adding the newline > - do the same to $cephfs_secret > > From previous version (though not sure if they still apply with these > changes):
good call for including them here > > Reviewed-by: Fabian Ebner <f.eb...@proxmox.com> > Tested-by: Fabian Ebner <f.eb...@proxmox.com> added those now that Fabian reconfirmed them for v2 too > > PVE/CephConfig.pm | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > applied, thanks! _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
