On 22/07/2021 15:06, Lorenz Stechauner wrote: > changes to v1: > * dropped commits, that were already applied in the mean time > * better commit messages > * dropped the 'new-filename' - using 'filename' instead > * error handling for unlink > * dropped check for `new FormData()` in pve-manager > * fixed commit for pve-http-server (deleting temp file on errors) > * check file extention in front end too > > note: two commits in total state, that they break/require some > versions of other repos. please do not forget to bump those and > create the accoring 'breaks' or 'requires'. > > > pve-http-server: > Lorenz Stechauner (1): > anyevent: move unlink from http-server to endpoint > > src/PVE/APIServer/AnyEvent.pm | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > > pve-storage: > Lorenz Stechauner (3): > status: move unlink from http-server to enpoint > status: remove sleep(1) in file upload > status: add checksum and algorithm to file upload > > PVE/API2/Storage/Status.pm | 44 +++++++++++++++++++++++++++++++------- > 1 file changed, 36 insertions(+), 8 deletions(-) > > > pve-manager: > Lorenz Stechauner (5): > ui: move upload window into UploadToStorage.js > ui: refactor UploadToStorage.js > ui/UploadToStorage: add checksum and algorithm > ui/UploadToStorage: add TaskViewer > ui/UplaodToStorage: check file extension > > www/manager6/Makefile | 1 + > www/manager6/storage/ContentView.js | 197 +--------------- > www/manager6/window/UploadToStorage.js | 311 +++++++++++++++++++++++++ > 3 files changed, 314 insertions(+), 195 deletions(-) > create mode 100644 www/manager6/window/UploadToStorage.js >
Two small nits I found when doing a shallow "smell test" review, else the direction looks OK. I do not want to tackle a in-depth review/test _and_ the two breaks in dependencies a day before my vacation, so I'm letting Fabian handle this, which has a better eye for those dependencies most of the time any way. The GUI can be reviewed by Dominik. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
