On 4/13/21 08:39, Thomas Lamprecht wrote:
On 12.04.21 17:32, Stefan Reiter wrote:
Treat filepaths like "/root.pxar.didx" without a trailing slash as
wanting to download the entire archive content instead of erroring. The
zip-creation code already works fine for this scenario.
Signed-off-by: Stefan Reiter <s.rei...@proxmox.com>
---
src/api2/admin/datastore.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
applied, thanks!
But that API is definitively weird in general...
just fyi
1. old style API definition, should use the #[api()] macro instead
the api macro cannot handle AsyncHttp api calls (yet?), but this is
required for the stream
2. perly "params: Value", yeah, no thanks.
a result from above, without api macro no de-structuring of parameters
3. hard coded return stream type, one should be able to download also a single
file as zip, and we knew that we wanted .tar then too, so not providing an
param for that is weird.
we always can add as much, but until now, generating a zip for a single
file was not really sensible
4. accessed via /json/ path but never returns json
all api calls need a formatter to call, should we add a
new one for download type?
_______________________________________________
pbs-devel mailing list
pbs-de...@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
