It turns out that we do not yet allow cloning from container templates
with bind mounts. So in a sense container templates with bind mounts are
currently misconfigured, and this patch would make it easier to get there...
Should I send a v2 with a patch making cloning from such templates
possible, or were there some concerns to not allow it in the first
place? There is a
# TODO: allow bind mounts?
comment in the clone API call.
Am 02.04.21 um 14:36 schrieb Fabian Ebner:
Restoring a backup of a template with a bind mount point failed, because the
volume_has_feature check would fail.
Fix this by skipping bind mounts on template creation. There is no check against
adding a bind mount with 'pct set' *after* converting to a template, so it
shouldn't be an issue if we also allow conversion if bind mounts are present
*at*
conversion time.
Signed-off-by: Fabian Ebner <f.eb...@proxmox.com>
---
src/PVE/LXC.pm | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index 6395d12..5a9f76d 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -1186,6 +1186,8 @@ sub template_create {
PVE::LXC::Config->foreach_volume($conf, sub {
my ($ms, $mountpoint) = @_;
+ return if $mountpoint->{type} eq 'bind';
+
my $volid = $mountpoint->{volume};
die "Template feature is not available for '$volid'\n"
@@ -1195,6 +1197,8 @@ sub template_create {
PVE::LXC::Config->foreach_volume($conf, sub {
my ($ms, $mountpoint) = @_;
+ return if $mountpoint->{type} eq 'bind';
+
my $volid = $mountpoint->{volume};
PVE::Storage::activate_volumes($storecfg, [$volid]);
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
