On 09.02.21 16:24, Stefan Reiter wrote:
> In most circumstances a pidfd gets closed automatically once the child
> dies, and that *should* be guaranteed by us calling SIGKILL - however,
> it seems that sometimes that doesn't happen, leading to leaked file
> descriptors[0].
> 
> Also add a small note to verbose mode showing when the late-cleanup
> actually happens, helped during debug.
> 
> [0] https://forum.proxmox.com/threads/cannot-shutdown-vm.83911/
> 
> Signed-off-by: Stefan Reiter <s.rei...@proxmox.com>
> ---
> 
> I'm puzzled by this, and I'm not entirely sure this is the full fix, but it 
> does
> seem like a good idea to close the fds explicitly anyway.
> 
>  qmeventd/qmeventd.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
>

applied, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Reply via email to