Suresh Rajagopal <sures...@gmail.com> writes: > version is passed via hiera. params.pp has the logic to decide the > package name based version. Is it a good practice to have this logic > in params.pp ?
The philosophy I use in my own modules is that params.pp should provide the best possible default based on the host OS version. But at the same time it should be a parameter, so it can be overriden by hiera to handle cases where that default is wrong. It's very rare when I have to do that. And when I do, it's usually only needed until params.pp can be updated to handle the case (e.g., when a package name has changed in a new version of an OS, and the module has not been updated to handle that new version). --jtc -- You received this message because you are subscribed to the Google Groups "Puppet Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-users+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-users/87k2ezi4vj.fsf%40wopr.acorntoolworks.com. For more options, visit https://groups.google.com/d/optout.