Hi Kyle, On 30 Jan 2016, at 01:27, Kyle Flavin <kyle.fla...@gmail.com> wrote:
> On Friday, January 29, 2016 at 3:44:24 PM UTC-8, Garrett Honeycutt wrote: > Hi Kyle, > > I think you have a scoping issue, try using the double colons for the > puppet class, such as 'class foreman-proxy::puppet inherits ::puppet'. > > You seem to be using inheritance correctly to override a resource, > though you are doing this between two modules. This pattern should be > avoided at all costs and will likely end in tears. > > http://docs.puppetlabs.com/guides/style_guide.html#class-inheritance > > Suggest that the puppet module manage the puppet.conf. > > I added the "::" and it allowed the client to run without an error, but I'm > getting the modules/puppet/templates/puppet.conf.erb template brought down on > the client, instead of modules/foreman-proxy/templates/puppet.conf.erb. Is > it possible to change that? First: inheritance should not be used whenever possible. Especially inheritance among modules. Second: your inherited class should overwrite (not re-declare) the file resource: class foreman-proxy::puppet inherits puppet { File['/etc/puppet/puppet.conf’] { content => template('foreman-proxy/puppet.conf.erb'), } } Third: the best option would be to add a template parameter to the puppet class: class puppet ( puppet_conf_template = ‘puppet/puppet.conf.erb’, ){ file { ‘/etc/puppet/puppet.conf’: content => template($puppet_conf_template), } ... } class foreman_proxy::puppet { class { ‘::puppet’: puppet_conf_template = ‘foreman_proxy/puppet.conf.erb’, } } Fourth: a hyphen in class names is deprecated in Puppet 4. You should switch to underscore (like in my example). > > I'm looking into another solution as well. The problem is, with the way our > manifests were written, there doesn't seem to be an easy way to extend for > edge cases like this without changing the original module. The module is on > thousands of servers, so I'm a little hesitant to change it. Fifth: add rspec-puppet (and beaker) tests to your modules. This will allow testing behaviour prior doing changes. Best, Martin > > -- > You received this message because you are subscribed to the Google Groups > "Puppet Users" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to puppet-users+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/puppet-users/4fd8baf6-398d-49d3-84b0-3fe7596886c3%40googlegroups.com. > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "Puppet Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-users+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-users/F1AD027E-5306-4AEF-9E1F-39198157A08C%40gmail.com. For more options, visit https://groups.google.com/d/optout.
