Their use of hiera_include is spaghetti codish and horrid. But a lot of puppet code is. For a framework to be flexible enough without supporting such horrors is seemingly impossible. You are right to be concerned. If it were me I'd redo them as puppet classes and see if that looks better. I'm not sure it really changes much other than appearing less scary.
Everything I say is my opinion ;) On 16 Jun 2015 21:09, "Dan White" <d_e_wh...@icloud.com> wrote: > From > https://docs.puppetlabs.com/references/latest/function.html#hierainclude > > To use hiera_include, the following configuration is required: > > • A key name to use for classes, e.g. classes. > • A line in the puppet sites.pp file (e.g. > /etc/puppetlabs/puppet/manifests/sites.pp) reading > hiera_include('classes'). *Note that this line must be outside any node > definition and below any top-scope variables in use for Hiera lookups.* > > (My italics) > > <my_opinion> > The way hiera_include is being used is just asking for unexpected effects. > </my_opinion> > > In the immortal words of Dennis Miller, "Of course that's just my opinion, > I could be wrong." > > “Sometimes I think the surest sign that intelligent life exists elsewhere in > the universe is that none of it has tried to contact us.” (Bill Waterson: > Calvin & Hobbes) > > > On Jun 16, 2015, at 02:09 PM, Neil <n...@iamafreeman.com> wrote: > > Whilst I don't like it, I'm intrigued as to what is scaring you? > > Looks like someone has modelled profiles in hiera/yaml rather than saying > > include profile::aa > > and having > > class profile::aa () { > include syslog > include ttys > .... > Perhaps they just felt like it? > > If you trust people puppet you are trusting them with the resources the > manifests are applied to. Probably best if they don't scare you ;) > On 16 Jun 2015 18:11, "Dan White" <d_e_wh...@icloud.com> wrote: > >> It scared the beans out of me when I found this code in a manifest I am >> tasked to update / refactor. >> Does this look as outrageously wrong to you all as it looks to me ? >> >> Variable names have been edited to protect the guilty >> >> class role::one { >> hiera_include('profile::aa') >> hiera_include('profile::bb') >> hiera_include('profile::cc') >> } >> ...and then in common.yaml: >> >> profile::aa : >> - syslog >> - ttys >> - ...(continues) >> >> “Sometimes I think the surest sign that intelligent life exists elsewhere in >> the universe is that none of it has tried to contact us.” (Bill Waterson: >> Calvin & Hobbes) >> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Puppet Users" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to puppet-users+unsubscr...@googlegroups.com. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/puppet-users/6abd7a96-10c9-4668-9996-e8a25917b1d7%40me.com >> <https://groups.google.com/d/msgid/puppet-users/6abd7a96-10c9-4668-9996-e8a25917b1d7%40me.com?utm_medium=email&utm_source=footer> >> . >> For more options, visit https://groups.google.com/d/optout. >> > > -- > You received this message because you are subscribed to the Google Groups > "Puppet Users" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to puppet-users+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/puppet-users/CAAohVBeW%2BEAFE5H%2BJ6q%3DyQH%2BfUKxJdAjJ7E8y%2Bh_jrRN%3D9d-cA%40mail.gmail.com > <https://groups.google.com/d/msgid/puppet-users/CAAohVBeW%2BEAFE5H%2BJ6q%3DyQH%2BfUKxJdAjJ7E8y%2Bh_jrRN%3D9d-cA%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > > -- > You received this message because you are subscribed to the Google Groups > "Puppet Users" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to puppet-users+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/puppet-users/0406ec23-790d-4e0a-80de-da62fdf941be%40me.com > <https://groups.google.com/d/msgid/puppet-users/0406ec23-790d-4e0a-80de-da62fdf941be%40me.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Puppet Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-users+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-users/CAAohVBejTeNq9jp28oeJ_vxiVVDpcUgmxhAaB_ZWFveV7tuyOQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
