Hi folks,
Today I upgraded puppetlabs/concat from 1.2.0 to 1.2.1 and immediately
ran into an error:
Error: Could not retrieve catalog from remote server: Error 400 on
SERVER: Order cannot contain '/', ':', or '
'. at /etc/puppet/modules/concat/manifests/fragment.pp:46 on node
radius-dev.nomadic-core.bris.ac.uk
Warning: Not using cache on failed catalog
Error: Could not retrieve catalog; skipping run
This seems to be due to this change in the code:
https://github.com/puppetlabs/puppetlabs-concat/commit/30fbfe11aaf6d9d90e2cbf8cb5e20f2bd7748123#diff-07b462a4b4082856b785d62dee4f7468
While I agree this change is more correct, I think it is going to break
a lot of people who naturally quote everything, e.g. order => '10'.
Perhaps this change should not have been in a minor revision of the
module as it changes behaviour.
My 'order' parameter does not contain those characters, it is simply a
string so I suspect we are running into this by using a third-party
Forge module with a bug. For now I've reverted to 1.2.0 to get my agents
to work again, and it will take some time for me to check all installed
third-party modules that use puppetlabs/concat.
Happy to raise this as a formal issue if necessary.
Thanks,
Jonathan
--
You received this message because you are subscribed to the Google Groups "Puppet
Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to puppet-users+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/puppet-users/55351E1C.4030405%40bristol.ac.uk.
For more options, visit https://groups.google.com/d/optout.
