On Monday, March 23, 2015 at 7:30:10 AM UTC-5, Jayapandian Ponraj wrote: > > https://tickets.puppetlabs.com/browse/FACT-163 > > TLDR: The custom fact loading logic has been changed in facter-2.0 from > recursive to only top level directories. This is definitely a change in > behaviour and must be marked > as a breaking change instead marked as an improvement. > >
I'm sorry you experienced this unpleasant surprise. I agree that it is a bit odd for the release notes to categorize this change as an "improvement", since it is (considered to be) an improvement primarily in the internal organization of Facter's implementation. Such a thing rarely rises to the level of a mention in a product's release notes at all. That it *is* mentioned may signal that you have some traction on the issue, at least with respect to documentation. > In puppet 2.7 and facter 1.6.7 we had defined custom facts in the > following locations > > /var/lib/puppet/lib/facter/*network*/cus_net_fact.rb > /var/lib/puppet/lib/facter/*network*/cus_net_fact2.rb > /var/lib/puppet/lib/facter/*os*/cus_os_fact.rb > > But after moving to puppet 3.x and facter 2.4 these facts are not > available due to the change https://tickets.puppetlabs.com/browse/FACT-163 > > The change in behaviour is not obvious and not documented clearly. > On the other hand, the recursive lookup behavior you describe is not documented *at all*. The Facter 1.7 docs are pretty similar to the Facter 2 docs here, and none of them would have lead me to suspect that Facter would perform recursive lookups for custom fact implementations. I completely understand that you would have liked clearer, more prominent notice of this change, but I cannot personally find any fault here -- you already have more documentation than it is reasonable to expect for a change in (previously) undocumented behavior. However, given that the change was, indeed, documented, you may be able to persuade PL to make that documentation more prominent. [...] > > * Is the change really needed? > Having the custom facts in different folders helps in categorization IMO. > OS, network, application facts can be kept at separate folders which > improves readability, > instead of all the scripts in the same folder. > > I'm sure the change was not *needed*, but it was judged an improvement. I suppose your angle here is to try to get recursive lookups restored to Facter. I think the chances of that are slim, but it's a reasonable topic for discussion. If you're serious, then you'd want also to file an RFE against Facter. Substantial positive response to the idea might improve its chances. John -- You received this message because you are subscribed to the Google Groups "Puppet Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-users+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-users/ec5dfac0-d1a9-41f8-8c26-e2ea682301f5%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
