On Monday, February 2, 2015 at 2:24:42 PM UTC-6, Garrett Honeycutt wrote:
 

> == Section 5 
> Why the arbitrary line length? Puppet's DSL does not have the ability to 
> break lines, such as '\' in bash, so imposing any limit does not buy 
> anything, certainly not readability. [...]
>


Agreed.

 

> == Section 9.6 
> This suggests that using symbolic modes (mode => 'u=rw,g=r,o=r') are 
> acceptable. What is the purpose of this? This decreases readability and 
> understanding. 
>
>

Agreed.

 

> == Section 10.2 
> Would add that includes should happen right after defining parameters 
> and before validation. 
>
>

Absolutely.

 

> == Section 10.4 
> Suggest adding that chaining arrow syntax should only be used with the 
> reference syntax and not between resources. The example below is a bad 
> use of the chaining arrows that leads to changing ordering by 
> inadvertently moving resources around. This is easy to do when merging 
> software. 
>


Excellent.


John

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-users+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/puppet-users/38932690-e7ab-4448-9e7c-931c487da79c%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to