I've always found that when creating modules I'd focus on creating class parameters out of the most important configuration options of whatever I'm managing. After that I'd add a similar approach as yours for "everything else". This is a good approach because your module becomes usable for all the use cases you're not applying but other people might want.
Nothing is more frustrating than finding a great module, but not being able to use it straight away because it is missing that vital configuration parameter! So in this light, I'd say your approach is good. It might be better if you single out the most commonly used parameters and expose them directly just for clarity, but it might not always provide usability/readability benefits. -- You received this message because you are subscribed to the Google Groups "Puppet Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-users+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-users/1445a47a-2619-4672-9572-ee02e208e13a%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.